Getting reviews

Thorough code reviews are one of Mozilla’s ways of ensuring code quality. Every patch must be reviewed by the module owner of the code, or one of their designated peers.

To request a review, you will need to specify a review group (starts with #). If there is not, you should select one or more usernames either when you submit the patch, or afterward in the UI. If you have a mentor, the mentor can usually either also review or find a suitable reviewer on your behalf.

For example, the syntax to request review from a group should be:

Bug xxxx - explain what you are doing and why r?#group-name

or

Bug xxxx - explain what you are doing and why r?developer-nickname

Getting attention: If a reviewer doesn’t respond within a week, or so of the review request:

  • Contact the reviewer directly (either via e-mail or on Matrix).

  • Join developers on Mozilla’s Matrix server, and ask if anyone knows why a review may be delayed. Please link to the bug too.

  • If the review is still not addressed, mail the reviewer directly, asking if/when they’ll have time to review the patch, or might otherwise be able to review it.

Review groups

Name

Owns

Members

#build or #firefox-build-system-reviewers

The configure & build system

Member list

#dom-workers-and-storage-reviewers

DOM Workers & Storage

Member list

#devtools-reviewers

Firefox DevTools

Member list

#fluent-reviewers

Changes to Fluent (FTL) files (translation).

Member list

#firefox-source-docs-reviewers

Documentation files and its build

Member list

#firefox-ux-team

User experience (UX)

Member list

#firefox-svg-reviewers

SVG-related changes

Member list

#geckoview-reviewers

Changes to GeckoView

Member list

#gfx-reviewers

Changes to Graphics code

Member list

#intermittent-reviewers

Test manifest changes

Member list

#layout-reviewers

Layout changes.

Member list

#linter-reviewers

tools/lint/*

Member list

#mozbase

Changes to Mozbase

Member list

#mozbase-rust

Changes to Mozbase in Rust

Member list

#nss-reviewers

Changes to Network Security Services (NSS)

Member list

#perftest-reviewers

Perf Tests

Member list

#platform-i18n-reviewers

Platform Internationalization

Member list

#preferences-reviewers

Firefox for Desktop Preferences (Options) user interface

Member list

#remote-debugging-reviewers

Remote Debugging UI & tools

Member list

#static-analysis-reviewers

Changes related to Static Analysis

Member list

#style or #firefox-style-system-reviewers

Firefox style system (servo, layout/style).

Member list

#webcompat-reviewers

System addons maintained by the Web Compatibility team

Member list

#webdriver-reviewers

Marionette and geckodriver (including MozBase Rust), and Remote Protocol with WebDriver BiDi, and CDP.

Member list

#webidl

Changes related to WebIDL

Member list

#xpcom-reviewers

Changes related to XPCOM

Member list

To create a new group, fill a new bug in Conduit::Administration. See bug 1613306 as example.