Getting reviews¶
Thorough code reviews are one of Mozilla’s ways of ensuring code quality. Every patch must be reviewed by the module owner of the code, or one of their designated peers.
To request a review, you will need to specify a review group (starts with #). If there is not, you should select one or more usernames either when you submit the patch, or afterward in the UI. If you have a mentor, the mentor can usually either also review or find a suitable reviewer on your behalf.
Getting attention: If a reviewer doesn’t respond within a week, or so of the review request:
Contact the reviewer directly (either via e-mail or on Matrix).
Join developers on Mozilla’s Matrix server, and ask if anyone knows why a review may be delayed. Please link to the bug too.
If the review is still not addressed, mail the reviewer directly, asking if/when they’ll have time to review the patch, or might otherwise be able to review it.
Review groups¶
Name |
Owns |
Members |
---|---|---|
#build or #firefox-build-system-reviewers |
The configure & build system |
|
#dom-workers-and-storage-reviewers |
DOM Workers & Storage |
|
#devtools-inspector-reviewers |
The devtools inspector tool |
|
#fluent-reviewers |
Changes to Fluent (FTL) files (translation). |
|
#firefox-source-docs-reviewers |
Documentation files and its build |
|
#firefox-ux-team |
User experience (UX) |
|
#firefox-svg-reviewers |
SVG-related changes |
|
#geckoview-reviewers |
Changes to GeckoView |
|
#gfx-reviewers |
Changes to Graphics code |
|
#intermittent-reviewers |
Test manifest changes |
|
#layout-reviewers |
Layout changes. |
|
#linter-reviewers |
tools/lint/* |
|
#marionette-reviewers |
Changes to Marionette |
|
#mozbase |
Changes to Mozbase |
|
#mozbase-rust |
Changes to Mozbase in Rust |
|
#perftest-reviewers |
Perf Tests |
|
#preferences-reviewers |
Firefox for Desktop Preferences (Options) user interface |
|
#remote-protocol-reviewers |
Remote protocol |
|
#remote-debugging-reviewers |
Remote Debugging UI & tools |
|
#static-analysis-reviewers |
Changes related to Static Analysis |
|
#style or #firefox-style-system-reviewers |
Firefox style system (servo, layout/style). |
|
#webcompat-reviewers |
System addons maintained by the Web Compatibility team |
|
#webdriver-reviewers |
Marionette and Geckodriver in Firefox |
|
#webidl |
Changes related to WebIDL |
|
#xpcom-reviewers |
Changes related to XPCOM |
To create a new group, fill a new bug in Conduit::Administration. See bug 1613306 as example.